alamb commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2922888436
I also agree we could make a query cancellation token work -- the potential challenges of that approach are: 1. We have to find some way to trigger the cancellation token when the streams are dropped 2. We have to update all operators to *also* check their cancellation tokens I don't see that this is fundamentally different than what this PR does (basically has HashAggregateStream "check" for cancellation every 64 batches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
