zhuqi-lucas commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2924931929
> I am currently against merging this as is, unless we get stuck in our search to find a proper way to solve this. Let's keep hacking at finding a good solution -- we are making progress at exploring approaches and we might be able to find a good solution in the short term. > > If we get stuck, we can then proceed with merging this PR as it is currently (overfit to aggregates). Got it @ozankabak , it seems the main point is (overfit to aggregates), we still not have unified solution, even we use cancellation, it's the same action that we also need to apply to each exec. Updated: I just updated the PR also support sort exec, also added end to end testing. Next steps: I also want to support it for datasource, it's for the case reading large file without aggregation. I will try to do this also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
