ozankabak commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2922512158
Pipeline-breaking operators creating cancellation issues is a universal problem -- this is not an `AggregateExec` issue. Therefore, I firmly believe that the solution has to be universal as well -- I don't agree with adding a `YieldStream` type construct to all such operators. IMO @berkaysynnada's suggestion to delegate this responsibility to sources is better than what is done here (more separation of concern, more maintainable), but I concede that it is not a perfect solution. Maybe we can find a universal solution akin to what @pepijnve suggested. Let's not merge this until we all agree on a solution. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
