alamb commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2922322640
I agree with @pepijnve that adding a yield to the producer is not clearly a better choice -- I think the issue is for streams like AggregateExec that can always make progress So while this PR wraps the input to the AggregateExecStream, I think logically the yielding is part of the AggregateExec itself. Thus I suggest not adding it to the output of DataSourceExec but instead leaving it as is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
