alamb commented on code in PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#discussion_r2115561327
##########
datafusion/common-runtime/src/common.rs:
##########
@@ -98,6 +103,71 @@ impl<R> Drop for SpawnedTask<R> {
}
}
+/// Number of batches to yield before voluntarily returning Pending.
Review Comment:
I poked around a bit more and found a better home for this, I think
https://github.com/apache/datafusion/blob/dd9c3a815d7b4af2ef503ea557332ecc700af318/datafusion/physical-plan/src/stream.rs#L510-L509
I'll move it around as I made the suggestion to move here
##########
datafusion/common-runtime/Cargo.toml:
##########
@@ -38,6 +38,10 @@ workspace = true
name = "datafusion_common_runtime"
[dependencies]
+arrow = { workspace = true }
+arrow-schema = { workspace = true }
Review Comment:
I don't think we need `arrow-schema` as `arrow` directly exports most of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
