zhuqi-lucas commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2921914352
> @zhuqi-lucas I took the liberty of moving the code again as I gave you a bad suggestion yesterday. > > I also updated the description as i think this PR now handles NoGrouping and actual groupings > > I am also going to rerun the benchmarks and give it a final review. > > @pepijnve is there any way you can confirm this fixes your issues too? > > Nice work @zhuqi-lucas Thank you @alamb, the code looks clear and beautiful now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
