alamb opened a new pull request, #14366: URL: https://github.com/apache/datafusion/pull/14366
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/issues/14256 ## Rationale for this change @waynexia 's comment on https://github.com/apache/datafusion/issues/14256#issuecomment-2614436290 got me thinking maybe the build time regression had something to do with the size of `Expr` So I poked around for ways to reduce the size, and I found that currently `Expr` is 272 bytes ## What changes are included in this PR? 1. Add a test for the size of `Expr` 2. Change `Expr::WindowFunction(WindowFunction`) --> `Expr::WindowFunction(Box<WindowFunction>) -- which drops the size of `Expr` from 272 to `112` bytes ## Are these changes tested? functionally by CI TODO: 1. test impact on build time 2. test impact on planning performance benchmarks <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
