alamb commented on code in PR #16207: URL: https://github.com/apache/datafusion/pull/16207#discussion_r2116011961
########## datafusion/expr/src/expr.rs: ########## @@ -330,7 +331,7 @@ pub enum Expr { /// [`ExprFunctionExt`]: crate::expr_fn::ExprFunctionExt AggregateFunction(AggregateFunction), /// Call a window function with a set of arguments. - WindowFunction(WindowFunction), + WindowFunction(Box<WindowFunction>), Review Comment: Maybe as a follow on experiment we can try to box Alias and OuterReferenceColumn too -- but I recommend not in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org