irenjj commented on code in PR #16016:
URL: https://github.com/apache/datafusion/pull/16016#discussion_r2106217418


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -287,6 +287,63 @@ pub enum LogicalPlan {
     Unnest(Unnest),
     /// A variadic query (e.g. "Recursive CTEs")
     RecursiveQuery(RecursiveQuery),
+    /// A node type that only exist during subquery decorrelation
+    /// TODO: maybe we can avoid creating new type of LogicalPlan for this 
usecase
+    DependentJoin(DependentJoin),
+}
+
+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+pub struct DependentJoin {
+    pub schema: DFSchemaRef,
+    // all the columns provided by the LHS being referenced
+    // in the RHS (and its children nested subqueries, if any) (note that not 
all outer_refs from the RHS are mentioned in this vectors
+    // because RHS may reference columns provided somewhere from the above 
join)
+    pub correlated_columns: Vec<Column>,

Review Comment:
   I think `data_type` is needed as well in `correlated_columns`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to