duongcongtoai commented on PR #16016: URL: https://github.com/apache/datafusion/pull/16016#issuecomment-2891463939
> Is it correct that the pass in this PR will allow us to remove the other existing more specialized decorrelate* subquery passes, aka close this ticket: Yes, this is the plan > Also, I wonder if you have based this implementation on the structure in any existing system (e.g. Calcite or DuckDB)? I think following the DataFusion model of "implement well know good patterns" it would be good to follow an existing structure unless there is a reason to diverge Prior to implementing this PR, I had briefly reviewed DuckDB’s approach a few months ago. At that time, they were still using a bottom-up strategy. Later, the second paper introduced the top-down approach, which this PR is based on. This implementation was done from scratch and has only minimal reference to existing systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
