iffyio commented on code in PR #1834:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1834#discussion_r2080638281
##########
tests/sqlparser_mssql.rs:
##########
@@ -100,48 +100,52 @@ fn parse_mssql_delimited_identifiers() {
#[test]
fn parse_create_procedure() {
- let sql = "CREATE OR ALTER PROCEDURE test (@foo INT, @bar VARCHAR(256)) AS
BEGIN SELECT 1 END";
+ let sql = "CREATE OR ALTER PROCEDURE test (@foo INT, @bar VARCHAR(256)) AS
BEGIN SELECT 1; END";
Review Comment:
I think this behavior is OK, we try to preserve roundtrip behavior where
possible but I'm suspecting that in this case, the effort required to work
around it would not be worth the return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
