aharpervc commented on code in PR #1834:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1834#discussion_r2078041514
##########
tests/sqlparser_mssql.rs:
##########
@@ -100,48 +100,52 @@ fn parse_mssql_delimited_identifiers() {
#[test]
fn parse_create_procedure() {
- let sql = "CREATE OR ALTER PROCEDURE test (@foo INT, @bar VARCHAR(256)) AS
BEGIN SELECT 1 END";
+ let sql = "CREATE OR ALTER PROCEDURE test (@foo INT, @bar VARCHAR(256)) AS
BEGIN SELECT 1; END";
Review Comment:
I think the semicolon is coming from `format_statement_list` here:
https://github.com/apache/datafusion-sqlparser-rs/blob/ac1c339666c68779ed7f20dc0fb3b7473b298f83/src/ast/mod.rs#L163-L165
Not sure if we need to change any of that in this PR. It seems odd that
semicolons _weren't_ part of the canonical SQL previously (it was written out
as `body = display_separated(body, "; ")` without the supplementary semi colon)
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
