zhuqi-lucas commented on PR #15380: URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2812614902
Also no regression for small data set: ```rust Benchmark sort_tpch1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ concat_batches_for_sort ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 153.49ms │ 144.12ms │ +1.07x faster │ │ Q2 │ 131.29ms │ 117.87ms │ +1.11x faster │ │ Q3 │ 980.57ms │ 986.92ms │ no change │ │ Q4 │ 252.25ms │ 205.13ms │ +1.23x faster │ │ Q5 │ 464.81ms │ 464.38ms │ no change │ │ Q6 │ 481.44ms │ 474.70ms │ no change │ │ Q7 │ 810.73ms │ 705.06ms │ +1.15x faster │ │ Q8 │ 498.10ms │ 503.96ms │ no change │ │ Q9 │ 503.80ms │ 530.64ms │ 1.05x slower │ │ Q10 │ 789.02ms │ 705.37ms │ +1.12x faster │ │ Q11 │ 417.39ms │ 438.07ms │ no change │ └──────────────┴──────────┴─────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 5482.89ms │ │ Total Time (concat_batches_for_sort) │ 5276.20ms │ │ Average Time (main) │ 498.44ms │ │ Average Time (concat_batches_for_sort) │ 479.65ms │ │ Queries Faster │ 5 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 5 │ └────────────────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
