zhuqi-lucas commented on PR #15380: URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2812330239
Tested latest PR, it seems regression again for current code... ```rust Benchmark sort_tpch10.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ concat_batches_for_sort ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 2243.52ms │ 1655.67ms │ +1.36x faster │ │ Q2 │ 1842.11ms │ 1350.11ms │ +1.36x faster │ │ Q3 │ 12446.31ms │ 12363.56ms │ no change │ │ Q4 │ 4047.55ms │ 2873.84ms │ +1.41x faster │ │ Q5 │ 4364.46ms │ 4644.86ms │ 1.06x slower │ │ Q6 │ 4561.01ms │ 4769.54ms │ no change │ │ Q7 │ 8158.01ms │ 10058.76ms │ 1.23x slower │ │ Q8 │ 6077.40ms │ 6947.77ms │ 1.14x slower │ │ Q9 │ 6347.21ms │ 6379.49ms │ no change │ │ Q10 │ 11561.03ms │ 15190.91ms │ 1.31x slower │ │ Q11 │ 6069.42ms │ 8268.64ms │ 1.36x slower │ └──────────────┴────────────┴─────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main) │ 67718.04ms │ │ Total Time (concat_batches_for_sort) │ 74503.14ms │ │ Average Time (main) │ 6156.19ms │ │ Average Time (concat_batches_for_sort) │ 6773.01ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 5 │ │ Queries with No Change │ 3 │ └────────────────────────────────────────┴────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
