zhuqi-lucas commented on PR #15380: URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2809956328
Thank you @Dandandan , i submit the first version with both fast and no regression at the same time. -------------------- Benchmark sort_tpch1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ concat_batches_for_sort ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 153.49ms │ 146.72ms │ no change │ │ Q2 │ 131.29ms │ 126.38ms │ no change │ │ Q3 │ 980.57ms │ 988.13ms │ no change │ │ Q4 │ 252.25ms │ 236.61ms │ +1.07x faster │ │ Q5 │ 464.81ms │ 471.17ms │ no change │ │ Q6 │ 481.44ms │ 485.58ms │ no change │ │ Q7 │ 810.73ms │ 725.17ms │ +1.12x faster │ │ Q8 │ 498.10ms │ 522.58ms │ no change │ │ Q9 │ 503.80ms │ 527.44ms │ no change │ │ Q10 │ 789.02ms │ 737.35ms │ +1.07x faster │ │ Q11 │ 417.39ms │ 470.56ms │ 1.13x slower │ └──────────────┴──────────┴─────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 5482.89ms │ │ Total Time (concat_batches_for_sort) │ 5437.69ms │ │ Average Time (main) │ 498.44ms │ │ Average Time (concat_batches_for_sort) │ 494.34ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 7 │ └────────────────────────────────────────┴───────────┘ -------------------- Benchmark sort_tpch10.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ concat_batches_for_sort ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 2243.52ms │ 1551.61ms │ +1.45x faster │ │ Q2 │ 1842.11ms │ 1339.78ms │ +1.37x faster │ │ Q3 │ 12446.31ms │ 12173.95ms │ no change │ │ Q4 │ 4047.55ms │ 3159.04ms │ +1.28x faster │ │ Q5 │ 4364.46ms │ 4478.49ms │ no change │ │ Q6 │ 4561.01ms │ 4622.45ms │ no change │ │ Q7 │ 8158.01ms │ 7864.92ms │ no change │ │ Q8 │ 6077.40ms │ 5681.92ms │ +1.07x faster │ │ Q9 │ 6347.21ms │ 5817.61ms │ +1.09x faster │ │ Q10 │ 11561.03ms │ 8888.58ms │ +1.30x faster │ │ Q11 │ 6069.42ms │ 5555.38ms │ +1.09x faster │ └──────────────┴────────────┴─────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main) │ 67718.04ms │ │ Total Time (concat_batches_for_sort) │ 61133.74ms │ │ Average Time (main) │ 6156.19ms │ │ Average Time (concat_batches_for_sort) │ 5557.61ms │ │ Queries Faster │ 7 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 4 │ └────────────────────────────────────────┴────────────┘ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
