rluvaton commented on PR #15610: URL: https://github.com/apache/datafusion/pull/15610#issuecomment-2800097814
> > Also, to have a fully working larger than memory sort, you need to spill in > > https://github.com/apache/datafusion/blob/362fcdfc7b9e00cb6126a0cbc41c9abb2637c563/datafusion/physical-plan/src/sorts/builder.rs#L74 > > > > In case the memory reservation is failing > > Could you elaborate? I don't get it. Look at the description for https://github.com/apache/datafusion/pull/15700 and the code for the PR it might clarify better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org