qstommyshu commented on code in PR #15610:
URL: https://github.com/apache/datafusion/pull/15610#discussion_r2040791232
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -615,6 +616,104 @@ async fn test_disk_spill_limit_not_reached() ->
Result<()> {
Ok(())
}
+// Test configuration `sort_max_spill_merge_degree` in external sorting
+// -------------------------------------------------------------------
+
+// Ensure invalid config value of `sort_max_spill_merge_degree` returns error
+#[rstest]
+#[case(0)]
+#[case(1)]
+#[tokio::test]
+async fn test_invalid_sort_max_spill_merge_degree(
+ #[case] sort_max_spill_merge_degree: usize,
Review Comment:
this #[case] syntax looks so elegant for writing repetitive tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
