Omega359 commented on PR #13527: URL: https://github.com/apache/datafusion/pull/13527#issuecomment-2800015976
I've spent some time looking at using ExecutionProps for this and while I think it'll work it's still a lot of churn. That churn is largely because of two reasons: 1. We would need to switch from &ExecutionProps to Arc<ExecutionProps> to eliminate cloning (otherwise there is a lot of lifetime issues with ScalarFunctionExpr). 2. OptimizerConfig - this one is strange - it copies some things from ExecutionProps instead of just using it directly. Either this weirdness needs to be expanded or OptimizerConfig needs to have a function to retrieve ExecutionProps ala how it does for ConfigOptions. Essentially, I think it'll be better than the ConfigOptions approach but not by a huge amount. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
