Omega359 commented on PR #13527: URL: https://github.com/apache/datafusion/pull/13527#issuecomment-2789803674
Not sure I'd call a clone or two overhead but I agree with you on the plumbing. It's a lot. In JVM land I would likely have used a thread local variable to hold a session id and have a static factory to be able to lookup the config based on that session id. While that could technically work here I think @tustvold has advised in the past the thread locals with tokio are not the way to go. I had thought of the simplify option but if you look at how that is implemented you would still have to thread the options through the Optimizer and would also require a signature change for OptimizerRule, the same as is required for this PR. It would be less invasive overall though. Your first option though, hmm. It would work well for config options but long term it wouldn't allow session variables. That could be a future problem to solve I guess. I'll look into what it would take to impl this option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
