xudong963 commented on code in PR #15539: URL: https://github.com/apache/datafusion/pull/15539#discussion_r2033436276
########## datafusion/datasource/src/statistics.rs: ########## @@ -410,23 +410,24 @@ pub async fn get_statistics_with_limit( } /// Generic function to compute statistics across multiple items that have statistics -fn compute_summary_statistics<T, I>( +/// If `items` is empty or all items don't have statistics, it returns `None`. Review Comment: The `Statistics::unknow()` requires `schema`(more spefically, the size of fields) to initial the columns statistics, but sometimes, we don't have the schema info, so to make the method more general, I change the return value to None if we can't get the schema. Fyi, I did the change in https://github.com/apache/datafusion/pull/15539/commits/1922c7ebb9b1e975adc8d98917892a020a60efb4#diff-d91fad8ab007c2f14c53e4730c70db0b29818d94c98425e4f44aff01f6950957R414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
