berkaysynnada commented on code in PR #15539: URL: https://github.com/apache/datafusion/pull/15539#discussion_r2030265464
########## datafusion/datasource/src/file_groups.rs: ########## @@ -263,7 +264,21 @@ impl FileGroupPartitioner { .flatten() .chunk_by(|(partition_idx, _)| *partition_idx) .into_iter() - .map(|(_, group)| FileGroup::new(group.map(|(_, vals)| vals).collect_vec())) + .map(|(_, group)| { + FileGroup::new( Review Comment: I agree. Calling `repartitioned()` from `DataSource` once would make us lose the all information, but you're right it's also very dangerous right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org