jayzhan211 commented on code in PR #15542:
URL: https://github.com/apache/datafusion/pull/15542#discussion_r2037273906
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -291,6 +296,7 @@ impl AggregateUDFImpl for FirstValue {
}
}
+// TODO: rename to PrimitiveGroupsAccumulator
Review Comment:
I think this kind of improvement is better to included in the same PR to
reduce confusion. Only changes that are independent is candidate to split into
smaller PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
