comphead commented on code in PR #15542:
URL: https://github.com/apache/datafusion/pull/15542#discussion_r2029478517
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -291,7 +202,121 @@ impl AggregateUDFImpl for FirstValue {
}
}
-struct FirstPrimitiveGroupsAccumulator<T>
+fn create_group_acc(
Review Comment:
```suggestion
fn create_group_accumulator(
```
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -291,7 +202,121 @@ impl AggregateUDFImpl for FirstValue {
}
}
-struct FirstPrimitiveGroupsAccumulator<T>
+fn create_group_acc(
+ args: AccumulatorArgs,
+ pick_first_in_group: bool,
+) -> std::result::Result<Box<dyn GroupsAccumulator>, DataFusionError> {
Review Comment:
we can use `DFResult` instead of Result with `DataFusionError`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
