rluvaton commented on PR #15608: URL: https://github.com/apache/datafusion/pull/15608#issuecomment-2789127156
I saw the pr from @ashdnazg and it is a better solution in my opinion as it does not depend need to know the number of available tokio tasks, and just make the read spill work - https://github.com/apache/datafusion/pull/15654 and although multi level merge sort should be implemented, @2010YOUY01 implementation (#15610) with adaption for `row_hash` in `AggregateExec` to use it might be the better way, so closing this `row_hash` code to update: https://github.com/apache/datafusion/blob/784df33f8930f91eada0d67aa5acc25a4c25cea2/datafusion/physical-plan/src/aggregates/row_hash.rs#L1053-L1085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
