rluvaton commented on code in PR #15608:
URL: https://github.com/apache/datafusion/pull/15608#discussion_r2030275339
##########
datafusion/physical-plan/src/sorts/streaming_merge.rs:
##########
@@ -133,6 +142,24 @@ impl<'a> StreamingMergeBuilder<'a> {
self
}
+ pub fn with_spill_manager(mut self, spill_manager: SpillManager) -> Self {
+ self.spill_manager = Some(spill_manager);
+ self
+ }
+
+ pub fn with_sorted_spill_files(
+ mut self,
+ sorted_spill_files: Vec<RefCountedTempFile>,
+ ) -> Self {
+ self.sorted_spill_files = sorted_spill_files;
+ self
+ }
+
+ pub fn with_max_blocking_threads(mut self, max_blocking_threads: usize) ->
Self {
+ self.max_blocking_threads = Some(max_blocking_threads);
+ self
+ }
Review Comment:
Need a better API than this, this is confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
