berkaysynnada commented on PR #15563: URL: https://github.com/apache/datafusion/pull/15563#issuecomment-2788800050
> > Let's make it incremental for consistency. > > @berkaysynnada: Looking at this again, I'm pretty sure it should actually be `Final`! On partially sorted input, with or without fetch, the SortExec will only emit once it has processed all its necessary input data (eventually cancelling the input stream early). I've updated the PR with a new fix commit. PartiallySorted case is actually the same of AggregateExec with an ordered group_by key. Final means the operator can only emit results after its inputs are fully consumed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
