berkaysynnada commented on PR #15563: URL: https://github.com/apache/datafusion/pull/15563#issuecomment-2788703235
> > @geoffreyclaude I'm going to merge if you're done with this? > > @berkaysynnada: Fine by me! We resolved the (unfortunately, necessary) semi-redundant common prefix field. > > Only remaining question is the Emission type: if it makes sense to leave it as `Both` you can merge, but if you think `Incremental` makes more sense I can do a quick new commit to change it. Let's make it incremental for consistency. We're thinking on this, and likely figure out a refactor to make all things more clear. (if you wonder, there is also an issue here https://github.com/apache/datafusion/pull/15479#issuecomment-2786362233. These two cases seem to be related and I believe I'll solve them all) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
