alamb commented on PR #15568: URL: https://github.com/apache/datafusion/pull/15568#issuecomment-2787162573
> My view for DynamicFilterSource is not that it's a public API in DataFusion. It's a private implementation detail / helper that internal implementations of dynamic PhysicalExpr can use to simplify implementing dynamic PhysicalExpr by making a DynamicFilterSource and wrapping it with DynamicPhysicalExpr. Maybe we expose it publically if there's enough demand for it but I think it'll be private to begin with. This might be a good thing to note in the comments of `DynamicFilterSource` to make it clearer to future readers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
