adriangb commented on PR #15568: URL: https://github.com/apache/datafusion/pull/15568#issuecomment-2786429909
My view for `DynamicFilterSource` is not that it's a public API in DataFusion. It's a private implementation detail / helper that internal implementations of dynamic `PhysicalExpr` can use to simplify implementing dynamic `PhysicalExpr` by making a `DynamicFilterSource` and wrapping it with `DynamicPhysicalExpr`. Maybe we expose it publically if there's enough demand for it but I think it'll be private to begin with. I realize this PR doesn't make that clear or structure the exports correctly atm. Probably makes sense for it to be a private module in the same crate as `HashJoinExec`, `SortExec`, etc. live. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
