2010YOUY01 opened a new pull request, #15610:
URL: https://github.com/apache/datafusion/pull/15610
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #14692
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
### Background for memory-limited sort execution
See figures in
https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/sorts/sort.rs
### Current limitation for reading back spill files
Let's say the memory buffer can only hold 10 batches, but there are 900
files spilled, the current implementation will try to merge 900 files at once,
and fail the query.
However, this scenario is possible to continue if it can only merge 10 files
at a time, re-spill, until there are only less than 10 spill files in total,
and finally read them back and merge them as the output.
### High-level approach of this PR
Added one configuration option for max spill merge degree (haven't
implemented now, in POC it's a hard-coded `const MAX_SPILL_MERGE_DEGREE` for
simplicity)
At the final stage of external sort, there are initial spill files to merge,
perform multi-pass read-merge-respill operation, the number of merged spill
file in the next pass is decided by the closet power of `MAX_SPILL_MERGE_DEGREE`
Example:
Initial spill files to merge: 900
max merge degree: 10
pass1: merge 900 files to 100 (closet power of 10) files
pass2: 100 -> 10
pass3: 10 -> final single output
Inside each pass the number of files to merge in each step is split as even
as possible, while is always <= max merge degree, see details in the
implementation.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Updated the `sort.rs` for multi-pass reading spill. The entry point for the
described logic is function `merge_spilled_files_multi_pass()`
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
To be done, I think it's adding varying `max_spill_merge_degree` to the sort
fuzzer.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
