2010YOUY01 commented on PR #15610:
URL: https://github.com/apache/datafusion/pull/15610#issuecomment-2782279871

   > BTW, row_hash uses the sort preserving merge stream as well and has 
similar problem, I think this should be a solution outside the sort exec
   
   I think the spilling-related problem in external aggregation is still 
larger-than-memory sort, the current aggregation implementation tries to 
re-implement the sort spilling logic which is already done in `ExternalSorter`. 
So the implementation is reusable by `row_hash` (with some modifications)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to