ding-young commented on PR #15589:
URL: https://github.com/apache/datafusion/pull/15589#issuecomment-2781281225

   @2010YOUY01 Instead of applying transformation on filter expression, I 
adjusted the rule to transform x=x into `x IS NOT NULL OR NULL`. This preserves 
the behavior where NULL = NULL evaluates to NULL, which is treated as FALSE in 
filter expressions.
   
   About the performance, I'm not 100% sure whether this rule worth the change, 
but I made this change because `IS NOT NULL OR NULL` was a bit better than 
actual comparision. 
   
![image](https://github.com/user-attachments/assets/75227289-e086-404e-ba7e-d3b8c85c1f53)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to