ding-young commented on code in PR #15589: URL: https://github.com/apache/datafusion/pull/15589#discussion_r2032229805
########## datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs: ########## @@ -2152,6 +2169,17 @@ mod tests { } } + #[test] + fn test_simplify_eq_not_self() { + let expr_a = col("c2").eq(col("c2")); + let expr_b = col("c2_non_null").eq(col("c2_non_null")); + let expected_a = col("c2").is_not_null().or(lit_bool_null()); + let expected_b = lit(true); Review Comment: I updated the comments. Thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org