Re: [PR] Migrate physical plan tests to `insta` (Part-1) [datafusion]

[via GitHub]

blaginin commented on code in PR #15313:
URL: https://github.com/apache/datafusion/pull/15313#discussion_r2007699927


##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1776,17 +1790,17 @@ mod tests {
         assert_eq!(batch.num_columns(), 2);
         assert_eq!(batch.num_rows(), 3);
 
-        let expected = vec![
-            "+---+--------------------+",
-            "| a | AVG(b)             |",
-            "+---+--------------------+",
-            "| 2 | 1.0                |",
-            "| 3 | 2.3333333333333335 |", // 3, (2 + 3 + 2) / 3
-            "| 4 | 3.6666666666666665 |", // 4, (3 + 4 + 4) / 3

Review Comment:
   sure, you can also put it after the assert if you want (just reference the 
lines) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org