wForget commented on code in PR #1555:
URL: https://github.com/apache/datafusion-comet/pull/1555#discussion_r2006926052
##########
native/core/src/parquet/mod.rs:
##########
@@ -641,6 +640,8 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
session_timezone: jstring,
) -> jlong {
try_unwrap_or_throw(&e, |mut env| unsafe {
+ let task_ctx = TaskContext::default();
Review Comment:
The `session_context` of comet operator plannar is customized to configure
`memory_pool` and `batch_size`, while the parquet datasource exec does not use
`memory_pool` but uses `batch_size`. So we may need to respect
`COMET_BATCH_SIZE` here.
https://github.com/apache/datafusion-comet/blob/main/native/core/src/execution/jni_api.rs#L262-L293
https://github.com/apache/datafusion/blob/30c457a0837ff88d6537456d0573e39814c51fad/datafusion/datasource/src/file_scan_config.rs#L182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
