parthchandra commented on code in PR #1578:
URL: https://github.com/apache/datafusion-comet/pull/1578#discussion_r2021910799
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometNativeScanExec.scala:
##########
@@ -53,29 +55,50 @@ case class CometNativeScanExec(
disableBucketedScan: Boolean = false,
originalPlan: FileSourceScanExec,
override val serializedPlanOpt: SerializedPlan)
- extends CometLeafExec {
+ extends CometLeafExec
+ with DataSourceScanExec {
Review Comment:
V2 sources will go thru BatchScanExec and at some point native_datafusion
can be extended to V2 by implementing a NativeBatchScanExec the same way Spark
extended V1 parquet to V2; the V2 path is a wrapper around V1. Mostly, people
reading Parquet do not bother going via the V2 APIs so it is not urgent for us
to support V2 in native_datafusion.
iceberg_compat is basically a bunch of lower level APIs that the iceberg
integration will call (eventually). In the meantime, I added the calls to these
APIs in the V1 path so we can test the APIs end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
