kazuyukitanimura commented on code in PR #1578: URL: https://github.com/apache/datafusion-comet/pull/1578#discussion_r2021779171
########## spark/src/main/scala/org/apache/spark/sql/comet/CometNativeScanExec.scala: ########## @@ -53,29 +55,50 @@ case class CometNativeScanExec( disableBucketedScan: Boolean = false, originalPlan: FileSourceScanExec, override val serializedPlanOpt: SerializedPlan) - extends CometLeafExec { + extends CometLeafExec + with DataSourceScanExec { Review Comment: IIRC `DataSourceScanExec` is for V1. Is this ok for future V2 support? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org