tomershaniii commented on code in PR #1747:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1747#discussion_r2009166436
##########
src/ast/mod.rs:
##########
@@ -6925,6 +6928,12 @@ pub enum SqlOption {
range_direction: Option<PartitionRangeDirection>,
for_values: Vec<Expr>,
},
+
+ TableSpace(TablespaceOption),
+
+ Union(Vec<Ident>),
+
+ TableEngine(TableEngine),
Review Comment:
Seems to be used all over (` ColumnOption`, `CreateConnector`,
`CreateSchema`, `Cache` & more)
looks like it's mainly used for the key/value variant.
IMO it makes sense to split out into a key/value type and a TableOption type
(which has a K/V variant).
I think we should save this for another PR, there is a lot of scope in this
one as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
