rkrishn7 commented on PR #15242: URL: https://github.com/apache/datafusion/pull/15242#issuecomment-2748735327
> > Unfortunately I don't think the problem is solved there. Upon further investigation, it seems like another problem exists with there being information loss between the logical and physical schemas. Specifically, when constructing the physical expression for a literal, the nullability is not determined by the already known schema. It is simply based on whether or not the literal is null. > > This can be observed by updating the implementation of `PhysicalExpr::is_nullable` for `Literal` to return `Ok(true)`. After that, the test suite passes successfully. > > I think this should be fixed. Specifically, the nullability of `Literal` should be derived from its surrounding context. Rather than defaulting to `self.value.is_null()`. But, I also think it's fair to say this is another issue outside the scope of this PR. > > Confirmed. If you don't mind could you file a followup issue for this and update the comment in the union_by_name.slt to note that issue. I think this fix is complete otherwise. @Omega359 Done! Issue [here](https://github.com/apache/datafusion/pull/15242#issuecomment-2746563234) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
