alamb commented on code in PR #15242:
URL: https://github.com/apache/datafusion/pull/15242#discussion_r2014999225
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2679,24 +2679,16 @@ impl Union {
Ok(Union { inputs, schema })
}
- /// When constructing a `UNION BY NAME`, we may need to wrap inputs
+ /// When constructing a `UNION BY NAME`, we need to wrap inputs
/// in an additional `Projection` to account for absence of columns
- /// in input schemas.
+ /// in input schemas or differing projection orders.
fn rewrite_inputs_from_schema(
- schema: &DFSchema,
+ schema: &Arc<DFSchema>,
inputs: Vec<Arc<LogicalPlan>>,
) -> Result<Vec<Arc<LogicalPlan>>> {
let schema_width = schema.iter().count();
let mut wrapped_inputs = Vec::with_capacity(inputs.len());
for input in inputs {
- // If the input plan's schema contains the same number of fields
Review Comment:
This does indeed seem to be an overzealous optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
