eliaperantoni commented on code in PR #15209:
URL: https://github.com/apache/datafusion/pull/15209#discussion_r1998206440
##########
datafusion/sql/tests/cases/diagnostic.rs:
##########
@@ -351,6 +351,36 @@ fn test_in_subquery_multiple_columns() -> Result<(),
Box<dyn std::error::Error>>
.collect::<Vec<_>>(),
vec!["Select only one column in the subquery"]
);
+ Ok(())
+}
+
+#[test]
+fn test_unary_op_plus_with_column() -> Result<()> {
+ // Test with a direct query that references a column with an incompatible
type
+ let query = "SELECT +/*whole*/first_name/*whole*/ FROM person";
+ let spans = get_spans(query);
+ let diag = do_query(query);
+ assert_eq!(diag.message, "+ cannot be used with Utf8");
+ assert_eq!(diag.span, Some(spans["whole"]));
+ Ok(())
+}
+#[test]
+fn test_unary_op_plus_with_non_column() -> Result<()> {
+ // create a table with a column of type varchar
+ let query = "SELECT /*whole*/+'a'/*whole*/ ";
Review Comment:
I would remove the span tags `/*whole*/` since they aren't used by the test
anyway
##########
datafusion/sql/src/expr/unary_op.rs:
##########
@@ -45,7 +45,18 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
{
Ok(operand)
} else {
- plan_err!("Unary operator '+' only supports numeric,
interval and timestamp types")
+ plan_err!("Unary operator '+' only supports numeric,
interval and timestamp types").map_err(|e| {
+ let span = operand.spans().and_then(|s| s.first());
+ let mut diagnostic = Diagnostic::new_error(
+ format!("+ cannot be used with {data_type}"),
+ span
+ );
+ if span.is_none() {
+ diagnostic.add_note("+ can only be used with
numbers, intervals, and timestamps", None);
+ diagnostic.add_help(format!("perhaps you need to
cast {operand}"), None);
+ }
Review Comment:
Why do this only when the `span` is `None`? I think it should always be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
