irenjj commented on PR #15253: URL: https://github.com/apache/datafusion/pull/15253#issuecomment-2731239713
> Thank you @irenjj -- this looks really nice > > I think there are a few ways we should improve the comments, ~but I'll directly push those to this branch.~ > > Thanks again! > > Update; I don't have time right now to make the comment changes. Let me know what you think @irenjj and if you are willing to make them in this PR. If not I'll make a follow on PR tomorrow. > > Thanks again ❤️ Thanks @alamb for your review, I will revise it later according to your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org