jayzhan211 commented on code in PR #15253: URL: https://github.com/apache/datafusion/pull/15253#discussion_r1999910359
########## datafusion/expr/src/expr.rs: ########## @@ -2607,11 +2793,23 @@ pub(crate) fn schema_name_from_exprs_comma_separated_without_space( schema_name_from_exprs_inner(exprs, ",") } +/// Get `sql_name` for Vector of expressions. +pub(crate) fn sql_name_from_exprs_comma_separated_without_space( Review Comment: `without_space` is the old format and ideally we should standardize the format #10364 so better not to introduce another format without good reason -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org