shehabgamin commented on PR #14392: URL: https://github.com/apache/datafusion/pull/14392#issuecomment-2708820627
> > > Would you have bandwidth to help with adding some initial tests in the Comet repo? I think if we have some examples then it will be easier for others to contribute. > > > > > > Yeah forsure. I'm working on pushing out the next Sail release tomorrow, but after that I'll have some bandwidth. > > What I recommend is: > > 1. Create a new PR with a new datafusion-functions-spark crate > > 2. Add one or two example functions to this crate, along with how the tests might look > > > Then once we get consensus on what the pattern looks like, we can gin up a project / spread the work to port over existing functions and tests from other projects / sources following that pattern Will get to this sometime this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
