vbarua commented on code in PR #15014: URL: https://github.com/apache/datafusion/pull/15014#discussion_r1982693060
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5893,15 +5889,11 @@ SELECT FIRST_VALUE(column1 ORDER BY column2) FROM t; ---- NULL -query I +query error DataFusion error: Error during planning: RESPECT NULLS and IGNORE NULLS are not supported for aggregate functions SELECT FIRST_VALUE(column1 ORDER BY column2) RESPECT NULLS FROM t; Review Comment: Ha, there's always another engine 😅 It looks like Spark defines a`first_value(expr[, isIgnoreNull])` function which takes an optional boolean parameter to control whether it ignore nulls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
