qazxcdswe123 opened a new pull request, #15014:
URL: https://github.com/apache/datafusion/pull/15014
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Partial fix for #15006
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
As per the issue says
> In the SQL standard, RESPECT NULLS and IGNORE NULLS are options to be set
for the lead, lag, first_value, last_value and nth_value window functions.
## What changes are included in this PR?
Adds validation to prevent using `RESPECT NULLS` and `IGNORE NULLS` with
aggregate functions
One thing to note that is:
> That being said, part of the weirdness here is that DataFusion defines
first_value both as an [aggregate
function](https://github.com/apache/datafusion/blob/main/datafusion/functions-aggregate/src/first_last.rs)
and as a [window
function](https://github.com/apache/datafusion/blob/dd0fd889ea603f929accb99002e2f99280823f5c/datafusion/functions-window/src/nth_value.rs#L41-L46).
Accroding to the sqllogic test, this should only affect aggregate function.
## Are these changes tested?
Essisting tests have coverd the cases
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Maybe? If one uses `RESPECT NULLS` and `IGNORE NULLS` with aggregate
functions then this is a breaking change
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
