vbarua commented on code in PR #15014: URL: https://github.com/apache/datafusion/pull/15014#discussion_r1981949757
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5893,15 +5889,11 @@ SELECT FIRST_VALUE(column1 ORDER BY column2) FROM t; ---- NULL -query I +query error DataFusion error: Error during planning: RESPECT NULLS and IGNORE NULLS are not supported for aggregate functions SELECT FIRST_VALUE(column1 ORDER BY column2) RESPECT NULLS FROM t; Review Comment: This is a bit of the weirdness I pointed out in https://github.com/apache/datafusion/issues/15006, which is that DataFusion has `first_value` as _both_ an aggregate and window function, whereas most other engines only have a window function form. This invocation is technically the aggregate function form, because there is no OVER clause which would be expected for a window function invocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
