andygrove commented on code in PR #1452:
URL: https://github.com/apache/datafusion-comet/pull/1452#discussion_r1975566498
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -1104,14 +1058,15 @@ mod test {
assert_eq!(9914, buffer.spill_file.as_ref().unwrap().file.len());
// append after spill
- let status = buffer.append_rows(batch.columns(), &indices, 0,
&metrics);
+ let status = buffer
+ .append_rows(batch.columns(), &indices, 0, &metrics)
+ .unwrap();
assert_eq!(
format!("{status:?}"),
- format!("{:?}", AppendRowStatus::MemDiff(Ok(0)))
+ format!("{:?}", AppendRowStatus::Appended)
);
assert_eq!(900, buffer.num_active_rows);
- // TODO reservation should not be zero because there are active
builders again
- assert_eq!(0, buffer.reservation.size());
+ assert_eq!(106496, buffer.reservation.size());
Review Comment:
This demonstrates that the memory accounting is now more accurate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
