andygrove commented on code in PR #1452:
URL: https://github.com/apache/datafusion-comet/pull/1452#discussion_r1975562414
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -793,10 +747,8 @@ impl PartitionBuffer {
let mut repart_timer = metrics.repart_time.timer();
self.active = new_array_builders(&self.schema, self.batch_size);
repart_timer.stop();
-
- mem_diff += self.active_slots_mem_size as isize;
}
- Ok(mem_diff)
Review Comment:
no need to return memory size here because we already reserved the memory in
this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
