andygrove commented on code in PR #1452:
URL: https://github.com/apache/datafusion-comet/pull/1452#discussion_r1974350259
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -294,7 +291,6 @@ struct ShuffleRepartitioner {
num_output_partitions: usize,
runtime: Arc<RuntimeEnv>,
metrics: ShuffleRepartitionerMetrics,
- reservation: MemoryReservation,
Review Comment:
This is the main change; removing the memory tracking in
`ShuffleRepartitioner` because we already track the memory in each instance of
`PartitionedBuffer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
